output: Add backup feature for bad chunks #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <[email protected]>
repeatedly
added
feature request
cosmo0920
reviewed
Apr 23, 2018
lib/fluent/plugin/output.rb
Outdated
| @@ -1115,6 +1149,21 @@ def try_flush | |||
| end | |||
| end | |||
|
|
|||
| def backup_chunk(chunk, using_secondary, delayed_commit) | |||
| unique_id = dump_unique_id_hex(chunk.unique_id) | |||
| safe_plugin_id = plugin_id.gsub(/[ \/\\:]/, '_') | |||
There was a problem hiding this comment.
This feature assumes to work on Windows?
If so, we should add more prohibiting to use characters:
/ > < ? : " \ * | ; are not permitted to use for filename on NTFS.
There was a problem hiding this comment.
Ah, good catch! Will add more characters.
|
I've added a comment about concerns on Windows environment. |
Signed-off-by: Masahiro Nakagawa <[email protected]>
Signed-off-by: Masahiro Nakagawa <[email protected]>
Signed-off-by: Masahiro Nakagawa <[email protected]>
|
The usage of this feature is hard to track down. Can it be added to the docs? |
|
@repeatedly Could you add the document about it. or had you already added? |
|
I Apologize for replying to an old issue. I am curious if there is a way to monitor the number of bad chunks, e.g., using Prometheus? |
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Jan 26, 2023
Backup feature was implemented in fluent#1952, but it didn't support handling broken file chunks found in resuming buffer. This extends the backup feature to support it. Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1856
Current implementation covers most bad chunk cases. I need feedback before writing test.
root_dirparameter for backup directory when specified,/${root_dir}/backup/worker${worker_id}/${plugin_id}/${chunk_id}.log.Signed-off-by: Masahiro Nakagawa [email protected]